getsentry / getsentry/sentry-javascript
Cloudflare Request and response attribute asymmetry against Deno
- Vorherrschende Sprache
- TypeScript
- Sterne
- 8.7k
- Forks
- 1.8k
- Ø Merge
- 1 T. 17 Std.
- Gemergte PRs (30 T.)
- 523
Beschreibung
`wrapRequestHandlerWithInit` does not do two things `wrapDenoRequestHandler` does:
* set response headers as span attributes via `httpHeadersToSpanAttributes(..., 'response')`
* set `isolationScope.setContext('response', { status_code })`
**Work item.** Decide which behavior is correct and make the two match. If Cloudflare deliberately skips response headers for payload-size reasons, say so in a comment.
Beitragsleitfaden
Rechercherichtung
Start by locating wrapRequestHandlerWithInit and wrapDenoRequestHandler, then compare their response handling, including httpHeadersToSpanAttributes and isolationScope.setContext. Decide which behavior should be shared; done means both handlers match, with a comment if Cloudflare intentionally omits response headers for payload-size reasons.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- deno, typescript
- Bereich
- observability
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Aktiv
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 72/100