getsentry / getsentry/sentry-javascript

Cloudflare Request and response attribute asymmetry against Deno

Open
#24,042 1 comment 0 reactions 0 assignees View on GitHub
Cloudflare Workers Improvement javascript Spans
Dominant language
TypeScript
Stars
8.7k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
515

Description

`wrapRequestHandlerWithInit` does not do two things `wrapDenoRequestHandler` does:

* set response headers as span attributes via `httpHeadersToSpanAttributes(..., 'response')`
* set `isolationScope.setContext('response', { status_code })`

**Work item.** Decide which behavior is correct and make the two match. If Cloudflare deliberately skips response headers for payload-size reasons, say so in a comment.

Contributor guide

Open the contributing guide

Research direction

Start by locating wrapRequestHandlerWithInit and wrapDenoRequestHandler, then compare their response handling, including httpHeadersToSpanAttributes and isolationScope.setContext. Decide which behavior should be shared; done means both handlers match, with a comment if Cloudflare intentionally omits response headers for payload-size reasons.

Written by the indexing model from the issue text.

Assessment

Tech stack
deno, typescript
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.