getsentry / getsentry/sentry-javascript
deno: tests run with `--no-check`
- Dominant language
- TypeScript
- Stars
- 8.7k
- Forks
- 1.8k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 523
Description
`packages/deno/package.json`: `deno test ... --no-check`. Type errors in Deno test files never fail CI. `lint:types` covers `src` only.
Either drop `--no-check`, or add a separate `deno check test/` step. Measure the added CI time first; `--no-check` may have been added for speed.
Contributor guide
Research direction
Start in packages/deno/package.json and inspect the deno test command using --no-check, alongside the lint:types coverage for src. Measure the added CI time for type-checking the test files, then choose whether removing --no-check or adding a separate deno check test/ step meets the goal. Done means Deno test-file type errors can fail CI without an unacceptable time increase.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- deno, typescript
- Domain
- ci-cd, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100