getsentry / getsentry/sentry-javascript
bun: `Bun.serve` spans lack client address and protocol attributes
- Vorherrschende Sprache
- TypeScript
- Sterne
- 8.7k
- Forks
- 1.8k
- Ø Merge
- 1 T. 17 Std.
- Gemergte PRs (30 T.)
- 515
Beschreibung
Deno sets `client.address`, `client.port` (honoring `x-forwarded-for`) and `network.protocol.name`. Bun sets none. Bun exposes the peer through `server.requestIP(request)`.
**Work item.** Thread the `Server` instance into `wrapRequestHandler` and set the three attributes, gated on `dataCollection.userInfo` the way Deno does.
Beitragsleitfaden
Rechercherichtung
Start at Bun.serve's wrapRequestHandler and compare the existing Deno implementation for client address, port, and network protocol attributes. Inspect Server.requestIP(request) and dataCollection.userInfo, then verify that the three attributes are present only under the same gate used by Deno.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- bun, typescript
- Bereich
- observability
- Issue-Typ
- Feature
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Aktiv
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 72/100