getsentry / getsentry/sentry-javascript

HTTP Headers are not sent by default, unless `sendDefaultPii` is enabled.

Ouverte
#20,706 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Docs
Langage dominant
TypeScript
Étoiles
8.7k
Forks
1.8k
Merge moyen
1 j 17 h
PR mergées (30 j)
515

Description

### SDK

JavaScript SDK

### Description

Sentry version:
```
"@sentry/browser": "10.51.0",
"@sentry/nextjs": "10.51.0",
```

The docs mention [here](https://docs.sentry.io/platforms/javascript/guides/nextjs/data-management/data-collected/#http-headers) that

> By default, the Sentry SDK sends HTTP response or request headers.

However, this is not true or needs clarifying since at least the NextJS SDK requires the SentryConfig to have `sendDefaultPii` to be true.

Response headers;
`sendDefaultPii` disabled;
Image

`sendDefaultPii` enabled;
Image

Request headers do seem to send headers but with some entries omitted, though this isn't mentioned on the docs.

### Suggested Solution

Depending what the expected behavior is here;

- If we do not expect to send headers by default, the docs should be updated here to mention that `sendDefaultPii` should be enabled for response headers and most request headers.
- If we do expect to send headers by default, there may be a bug in the Sentry JavaScript SDK.

Also, it would be useful to understand what exactly is and isn't included behind the `sendDefaultPii` field to make a decision if we should enable this or not. Perhaps also linking to the data-collected page from the interface/config API [here](https://docs.sentry.io/platforms/javascript/configuration/options/#sendDefaultPii).

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.