getsentry / getsentry/sentry-javascript

[Nestjs] Instrument Controllers

Ouverte
#18,485 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Improvement Nest.js
Langage dominant
TypeScript
Étoiles
8.7k
Forks
1.8k
Merge moyen
1 j 17 h
PR mergées (30 j)
515

Description

I noticed that we do not have any tracing for nest [controllers](https://docs.nestjs.com/controllers) atm. I'd assume that many people use nest as a REST service, in which case controllers are the entry points for any incoming requests.

Solution Brainstorm:

* All controllers have a `@Controller` decorator. Individual endpoints also have annotations for the request type (e.g. `@Get`).
* We can hook into one of these annotations as we for instance already do for the `@Injectable` decorator.
* We need to check if all annotations are actually required or if users can omit them (for instance if we omit the request type annotation it might default to a GET endpoint).

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.