getsentry / getsentry/sentry-javascript

Unify console instrumentation to a single integration

Abierto
#17,702 2 comentarios 1 reacción 0 asignados Ver en GitHub
Meta: Breaking Task
Lenguaje dominante
TypeScript
Estrellas
8.7k
Forks
1.8k
Merge medio
1 d 17 h
PR fusionados (30 d)
515

Descripción

### Description

Our console instrumentation is spread across different sdks and integrations, making for a confusing set up experience. We should try to unify this to be a single integration in the next major version of the SDK. This also allows us to look at enabling sending logs by default via console logs if `enableLogs` is set to `true`.

Our ideal end state is a single console integration that captures breadcrumbs by default, captures logs if `enableLogs` is set to `true`, and optionally captures errors if configured by users. This allows us to delete `captureConsoleIntegration`, and simplify `breadcrumbsIntegration` in browser (something we've wanted to do for a long time).

- `@sentry/core` - `consoleIntegraiton` (captures console as breadcrumbs): https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/instrument/console.ts
- `@sentry/core` - `consoleLoggingIntegration` (captures console as logs): https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/logs/console-integration.ts
- `@sentry/core` - `captureConsoleIntegration` (captures console as errors): https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/integrations/captureconsole.ts
- `@sentry/browser` - `breadcrumbsIntegration` (captures console as breadcrumbs): https://github.com/getsentry/sentry-javascript/blob/develop/packages/browser/src/integrations/breadcrumbs.ts
- `@sentry/deno` - `denoIntegration` (captures console as breadcrumbs): https://github.com/getsentry/sentry-javascript/blob/develop/packages/deno/src/integrations/breadcrumbs.ts

the `instrumentConsole` utility: https://github.com/getsentry/sentry-javascript/blob/5df78df4a3c1419c33bf9cacc9899a22fa73c5c1/packages/utils/src/instrument.ts#L109

Previous: https://github.com/getsentry/sentry-javascript/issues/4532

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.