getsentry / getsentry/sentry-javascript

GlobalHandlers: Use event handlers instead of monkey-patching `window.onerror`

Offen
#17,217 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Improvement
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
515

Beschreibung

### Description

Today, our `globalHandlersIntegration` monkey-patches `window.onerror` and `window.onunhandledrejection` directly. While this worked generally fine, it has the disadvantage that any party could come in with an improper monkey patch and remove Sentry form the listener chain.

Instead, we could use `window.addEventListener('error')` (same for unhanded rejection).

While we get the same data, this has the advantage that the SDK can't be removed by accident.

Compatibility-wise, using event handlers [should be fine](https://caniuse.com/?search=addeventlistener).

Which leaves us with the thing we need to investigate carefully: Compatibility with our loader script.
This is the reason why we currently still use `onerror`:

https://github.com/getsentry/sentry-javascript/blob/faada7ca942403bba2627208a7e5a4516606dbeb/packages/core/src/instrument/globalError.ts#L22-L23

However, we're not (yet) sure if this is actually a concern. Whatever we do here, we need to ensure that behaviour for the loader doesn't change and vice versa.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.