getsentry / getsentry/sentry-javascript

Feature Flags: Support for the `flags` package

Aperta
#16,168 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Feature Feature: Feature Flags
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
515

Descrizione

### Description

The [`flags` npm package]() from vercel is getting quite popular:

![Image](https://uploads.linear.app/3ed206af-f87a-40aa-82a0-150bf83e43e6/899dd246-1aa9-4f19-8e0c-0d4dc79b6e0b/743f5801-7a0f-4637-b1f7-77980d9e0914?signature=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwYXRoIjoiLzNlZDIwNmFmLWY4N2EtNDBhYS04MmEwLTE1MGJmODNlNDNlNi84OTlkZDI0Ni0xYWE5LTRmMTktOGUwYy0wZDRkYzc5YjZlMGIvNzQzZjU4MDEtN2EwZi00NjM3LWIxZjctNzc5ODBkOWUwOTE0IiwiaWF0IjoxNzc1ODU3NTMzLCJleHAiOjE4MDc0MjgwOTN9.q4hFulBckDkZKy51RkpXohhnrkkYb16hsr8oN5Jvrxo)

Since Sentry now has support for capturing feature flags from the client, so that events and spans are tagged with the relevant flags.
This ticket suggesting expanding the JS support for the `flags` package.

@dferber90 from Vercel created a gist where we can get a list of flags evaluated in a way that supports streaming:

[https://gist.github.com/dferber90/da452f324bb4a06d649a2000a5c7d881]()

Whether we create a `@sentry/flags` or add it to the core so we can reuse it more easily across other frameworks might depend on the bundle size impact, so that needs to be tested.

This bit could become a core part of the SDK itself though that could be part of a separate task:

[https://github.com/getsentry/sentry-javascript/blob/a67ebc4f56fd20259bffbe194e8e92e968589c12/packages/browser/src/utils/featureFlags.ts#L20-L34]()

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.