getsentry / getsentry/sentry-javascript

Sentry can't instument express if it is bundled

Ouverte
#15,017 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Improvement Node.js
Langage dominant
TypeScript
Étoiles
8.7k
Forks
1.8k
Merge moyen
1 j 17 h
PR mergées (30 j)
523

Description

### Is there an existing issue for this?

- [x] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- [x] I have reviewed the documentation https://docs.sentry.io/
- [x] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

### How do you use Sentry?

Sentry Saas (sentry.io)

### Which SDK are you using?

@sentry/node

### SDK Version

8.48.0

### Framework Version

Express 4.21.2

### Link to Sentry event

_No response_

### Reproduction Example/SDK Setup

_No response_

### Steps to Reproduce

Use sentry for node in an angular ssr appllication that is based on express.

### Expected Result

Sentry can instrument express

### Actual Result

Sentry comlains that express is not instrumented even through the instrument file was preloaded with `--import`.

My guess is that since angular bundles express into the server, sentry misses out on the import that it tries to wrap, leading to it not instrumenting express. I would be thankful for some ideas on how this could be improved.
Also if it is just adding a bunch of middlewares and such

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.