getsentry / getsentry/sentry-javascript

Cron: Add support for parsing Luxon zones

Open
#13,820 3 comments 0 reactions 0 assignees View on GitHub
Checks Crons Improvement Node.js
Dominant language
TypeScript
Stars
8.7k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
515

Description

### Problem Statement

The [cron](https://github.com/kelektiv/node-cron) package uses Luxon for time zones. This allows us to specify `system` to use the system timezone for example. Information about this can be found here: https://github.com/moment/luxon/blob/master/docs/zones.md#specifying-a-zone

However, the problem that currently stands is that these zones aren't supported and thus cause Sentry to show an invalid monitor configuration error for new cron jobs.

![luxon-zones](https://cdn.serenmodz.rocks/QazpQ1jb.png)

### Solution Brainstorm

I believe that Sentry should parse Luxon zones in the automatic cron instrumentation, before sending them to the API. While I do mention providing `system` (which is also the default if not provided), It's still a limitation to what can be provided. I have included a link to the documentation along with an image for such.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.