getsentry / getsentry/sentry-java
Align callback error handling with other SDKs
- Lenguaje dominante
- Kotlin
- Estrellas
- 1.4k
- Forks
- 478
- Merge medio
- 2 d 23 h
- PR fusionados (30 d)
- 67
Descripción
### Description
Currently Java SDK does not follow the [new spec for callbacks](https://github.com/getsentry/sentry-docs/pull/19189).
If an error happens in a customer callback (hook), the SDK should fall back according to spec.
Gaps in Java SDK:
- `beforeBreadcrumb`: on error the breadcrumb is added as is, it should be dropped instead
- `eventProcessor`: on error the event/telemetry goes further in the pipeline, it should be dropped instead
Client reports:
- there's a new discard reason `callback_error ` (https://develop.sentry.dev/sdk/telemetry/client-reports/#discard-reasons-1) which should be used to make this distinguishable from things being filtered out on purpose.
Guía de contribución
Línea de trabajo
Start by tracing the Java SDK handling for the beforeBreadcrumb and eventProcessor callbacks, then inspect how client-report discard reasons are represented. The work is complete when callback errors drop the breadcrumb or event and record the callback_error discard reason, matching the referenced callback specification.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java
- Área
- tooling
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Activo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 66/100