getsentry / getsentry/sentry-java

Run the Integration.register() loop off the main thread (two-phase init)

未关闭
#5,704 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Android Improvement Platform: Java
主要语言
Kotlin
星标
1.4k
派生
478
平均合并
2 天 23 小时
30 天内合并 PR
67

描述

## Problem

`Sentry.init` registers all integrations synchronously on the calling thread (`sentry/src/main/java/io/sentry/Sentry.java:374-385`) — the main thread under auto-init. With ~17 default Android integrations this is the biggest remaining *block* of main-thread init work once the per-integration items (NDK etc.) are fixed.

## Proposal

Keep a minimal synchronous core — options, scopes, `SentryClient` binding, `UncaughtExceptionHandlerIntegration` — and submit the rest of the registration loop to `options.getExecutorService()`, with an opt-in marker for integrations that genuinely need the main thread (`AppLifecycleIntegration` already self-posts when off-main).

`Sentry.captureX` immediately after `init()` keeps working: the client is bound synchronously and events queue on the transport.

## Constraints

* The deliberate startup-crash blocking flush (`sentry-android-core/.../SendCachedEnvelopeIntegration.java:151-161`) must still block `init()` — needs an explicit carve-out.
* Integration ordering guarantees (NDK before outbox watcher, AppLifecycle before ANR, ANR before Replay — see comments in `AndroidOptionsInitializer.installDefaultIntegrations`) must be preserved. The single-threaded executor keeps submission order, but mixed sync/async registration could break it; audit each.
* Session auto-start + `isForegroundImportance()` at the end of `SentryAndroid.init` (`SentryAndroid.java:184-203`) depend on integration state (LifecycleWatcher) — decide whether they move too.

Concrete follow-up to getsentry/sentry-java#5475 ("Move more init code async").

贡献指南

打开贡献指南

调研方向

Start with the registration loop in sentry/src/main/java/io/sentry/Sentry.java:374-385 and the ordering comments in AndroidOptionsInitializer.installDefaultIntegrations. Then inspect SendCachedEnvelopeIntegration.java:151-161 and SentryAndroid.java:184-203. Done means defining the synchronous and executor-backed phases while preserving startup-crash flushing, integration ordering, and session or foreground-state behavior.

由索引模型根据 Issue 内容生成。

评估

技术栈
android, java
领域
mobile-dev, performance
Issue 类型
重构
难度
5/5
预计耗时
一周以上
活跃度
冷清
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。