getsentry / getsentry/sentry-java
Improve Stacktrace truncation for StackOverflowError
- Vorherrschende Sprache
- Kotlin
- Sterne
- 1.4k
- Forks
- 478
- Ø Merge
- 2 T. 23 Std.
- Gemergte PRs (30 T.)
- 67
Beschreibung
### Problem Statement
We've had reports of [dropped events in the past](https://github.com/getsentry/sentry-java/issues/2988) and in response implemented a [simple limit of 100 frames](https://github.com/getsentry/sentry-java/blob/b66ccf37e6b3000d423c8162a56173ccaeba1ab9/sentry/src/main/java/io/sentry/SentryStackTraceFactory.java#L62-L65).
This limit only uses 100 frames from one side of the stacktrace, leading to potentially unhelpful information shown in our product.
### Solution Brainstorm
In the next major, we could improve the truncation to:
- only trigger on `StackOverflowError` so we do not lose information on smaller stack traces
- this way we don't butcher other stacktraces
- truncate from the middle, i.e. keep frames on both ends of the stacktrace, hopefully truncating only some of the recurring part but keeping the most important frames, see [relay](https://github.com/getsentry/relay/pull/3905/files)
- keep 500 frames from both ends of the stacktrace, i.e. 1000 total frames to be compatible with relay potentially bumping their limit
NOTE: there is a risk of running out of sync with relays implementation / truncation numbers
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.