getsentry / getsentry/sentry-java

Add Fragment Transactions

Aberta
#3,719 4 comentários 4 reações 1 responsável Reivindicada por @markushi Ver no GitHub
Android Feature Spans
Linguagem predominante
Kotlin
Estrelas
1.4k
Forks
478
Merge médio
3d 4h
PRs com merge (30d)
72

Descrição

### Description

In the light of #1810, we're still not really there yet with the Manual Screens API and only-spans, so this might be a interim solution to support single-activity apps and create transactions bound to scope automatically for our fragment integration. This has several tricky things to figure out:
- What is considered a screen when fragments are used?
- If androidx.navigation is used we could use our integration to create transaction whenever a route changes
- otherwise we could by default always create transaction and then provide a lambda/function to customize this behavior (e.g. `shouldCreateTx: (Fragment) -> Boolean`
- If there's an active Activity transaction, should we keep it or should we replace it with the Fragment one?
- I think we should keep it and make the fragment integration create a span instead
- Should inherit most of the behavior from the ActivityLifecycleIntegration, so it would makes sense to commonize that code
- TTID/TTFD
- ...
- ViewPager?

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.