getappmap / getappmap/appmap-python

The agent keeps a reference to an instrumented function that prevents it from being garbage collected

Ouverte
#317 0 commentaires 0 réactions 1 personne assignée Voir sur GitHub

@apotterri y travaille déjà.

Depuis le 24/5/2024.

bug
Langage dominant
Python
Étoiles
104
Forks
17
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

https://github.com/pallets/flask

============================================================== FAILURES ==============================================================
__________________________________________________ test_app_freed_on_zero_refcount ___________________________________________________

    @require_cpython_gc
    def test_app_freed_on_zero_refcount():
        # A Flask instance should not create a reference cycle that prevents CPython
        # from freeing it when all external references to it are released (see #3761).
        gc.disable()
        try:
            app = flask.Flask(__name__)
            assert app.view_functions["static"]
            weak = weakref.ref(app)
            assert weak() is not None
            del app
>           assert weak() is None
E           AssertionError: assert <Flask 'test_basic'> is None
E            +  where <Flask 'test_basic'> = <weakref at 0x11b897b50; to 'Flask' at 0x11bcc5150>()

tests/test_basic.py:1888: AssertionError
--------------------------------------------------------- Captured log call ----------------------------------------------------------
INFO     _appmap.recording:recording.py:77 writing /Users/kgilpin/source/land-of-apps/pallets-flask/tmp/appmap/pytest/test_app_freed_on_zero_refcount.appmap.json
========================================================== warnings summary ==========================================================
venv/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:274
  /Users/kgilpin/source/land-of-apps/pallets-flask/venv/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:274: PytestAssertRewriteWarning: Module already imported so cannot be rewritten: _appmap
    self.config.issue_config_time_warning(

venv/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:274
  /Users/kgilpin/source/land-of-apps/pallets-flask/venv/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:274: PytestAssertRewriteWarning: Module already imported so cannot be rewritten: appmap
    self.config.issue_config_time_warning(

tests/test_basic.py::test_server_name_subdomain
  /Users/kgilpin/source/land-of-apps/pallets-flask/venv/lib/python3.10/site-packages/_appmap/instrument.py:92: UserWarning: Current server name 'foo.localhost' doesn't match configured server name 'dev.local'
    ret = f.fn(*args, **kwargs)

tests/test_basic.py::test_subdomain_matching_other_name[False]
tests/test_basic.py::test_subdomain_matching_other_name[True]
  /Users/kgilpin/source/land-of-apps/pallets-flask/venv/lib/python3.10/site-packages/_appmap/instrument.py:92: UserWarning: Current server name '127.0.0.1:3000' doesn't match configured server name 'localhost.localdomain:3000'
    ret = f.fn(*args, **kwargs)

tests/test_reqctx.py::test_proper_test_request_context
  /Users/kgilpin/source/land-of-apps/pallets-flask/venv/lib/python3.10/site-packages/_appmap/instrument.py:92: UserWarning: Current server name 'localhost' doesn't match configured server name 'localhost.localdomain:5000'
    ret = f.fn(*args, **kwargs)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================== short test summary info =======================================================
FAILED tests/test_basic.py::test_app_freed_on_zero_refcount - AssertionError: assert <Flask 'test_basic'> is None
================================== 1 failed, 469 passed, 7 skipped, 6 warnings in 85.70s (0:01:25) ===================================

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.