getappmap / getappmap/appmap-java
ArrayArgumentsSystem incorrectly validates empty argument lists
Open
Nobody has claimed this yet.
bug
- Dominant language
- Java
- Stars
- 88
- Forks
- 17
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 1
Description
When targetParameters is empty, true is always returned
https://github.com/applandinc/appmap-java/blob/master/src/main/java/com/appland/appmap/transform/annotations/ArgumentArraySystem.java#L71-L97
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/main/java/com/appland/appmap/transform/annotations/ArgumentArraySystem.java at lines 71-97 and inspect how validation handles an empty targetParameters list. Confirm the current behavior and determine the expected validation result for empty argument lists; done means the behavior no longer incorrectly returns true in that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100