Autocomplete mode
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- php
- Domain
- backend-api-design
Research direction
Review PRs #1118 and #1119, then inspect the query classes under src/Common/Query and the providers that offer autocomplete. Determine whether autocomplete needs a consistent query abstraction or a flexible mode option; done means the project has an agreed design and implementation scope.
Written by the indexing model from the issue text.
Description
The last 2 PR are aiming to add autocomplete support.
I like the idea but I think we need to figure out a consistent way to implement that across all providers that offer autocompletion.
#1118 by @nassuf
$query->withData('autocomplete', true);
#1119 by @gdw96
$query->withData('mode', GoogleMapsPlaces::GEOCODE_MODE_AUTOCOMPLETE);
Personally, I would go for a new AutocompleteQuery class (see src/Common/Query) so we make it consistent and structured for every provider.
That being said, we would probably need to check how many provider offer autocompletion to see if it worth it.
Otherwise, I would go for solution 2 here above that seems more flexible.
Any insight on this topic @Nyholm @willdurand ?
- Dominant language
- PHP
- Stars
- 4k
- Forks
- 525
- Avg merge
- 8m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from geocoder-php/Geocoder
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
geocoder-php/Geocoder#1272 ·
-
question
Difficulty 4/5 3-5 days Newbie friendliness 25/100
geocoder-php/Geocoder#1267 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
geocoder-php/Geocoder#1266 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 38/100
geocoder-php/Geocoder#1244 · 2 comments · 2 reactions ·
-
provider
Difficulty 4/5 3-5 days Newbie friendliness 30/100
geocoder-php/Geocoder#1243 ·
All issues in geocoder-php/Geocoder
Similar issues
-
sync-en
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
-
sync-en
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
-
Перевод устарел
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
-
[6.x]: "Cannot use object of type stdClass as array" loading Users index (regression of #19182) Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100