geocoder-php / geocoder-php/Geocoder
Wrong LocationIQ Bounds
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 4k
- Forks
- 525
- Avg merge
- 8m
- Merged PRs (30d)
- 1
Description
In the LocationIQ provider, bounds are passed to the AddressBuilder in the wrong order.
$builder->setBounds((float) $bounds['south'], (float) $bounds['north'], (float) $bounds['west'], (float) $bounds['east']);
should really be
$builder->setBounds((float) $bounds['south'], (float) $bounds['west'], (float) $bounds['north'], (float) $bounds['east']);
according to the function signature of AddressBuilder.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the LocationIQ provider code that passes bounds to AddressBuilder and compare the call with AddressBuilder's function signature. Correct the argument order shown in the issue, then verify that the provider's bounds handling uses south, west, north, and east in the expected positions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100