gbionics / gbionics/osqp-eigen

Permit to set adaptive_rho related parameters even in embedded mode or if profiler is not defined with osqp v1.0

Open
#174 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
503
Forks
133
PR merge metrics
No merged PRs in 30d

Description

See:
* https://github.com/osqp/osqp/blob/4532d356f08789461bc041531f22a1001144c40a/include/public/osqp_api_types.h#L71-L74
* https://github.com/osqp/osqp/blob/release-0.6.3/include/types.h#L144-L151
* https://github.com/robotology/osqp-eigen/blob/e535f6faeda431a69a24dc3cdf0ff68541fe37c1/src/Settings.cpp#L79-L89

More in general we need to review any use of `EMBEDDED` or `PROFILING` in osqp v1.0 as the macro changed name.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/Settings.cpp and compare the linked osqp_api_types.h and release-0.6.3 include/types.h definitions. Review the uses of EMBEDDED and PROFILING for OSQP v1.0's renamed macros, then verify that adaptive_rho-related parameters can be set in embedded mode and when profiling is not defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.