gbdev / gbdev/gb-asm-tutorial

Update to RGBDS 1.0 syntax and features

Aperta
#131 1 commento 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
Assembly
Stelle
179
Fork
64
Merge medio
7g 22h
PR unite (30g)
1

Descrizione

The tutorial has been written gradually over years by different authors, and in that time, RGBDS syntax has been through pretty many changes. Now that it's reached v1.0.0 the syntax is stable enough that I think it would be worth going through the code in the tutorial and ensuring that it's valid and idiomatic for the latest RGBDS.

(For example, [the Galactic Armada Makefile](https://github.com/gbdev/gb-asm-tutorial/blob/master/galactic-armada/Makefile) has `$(GFX) -c "#FFFFFF,#cfcfcf,#686868,#000000;"`, which would now idiomatically be `$(GFX) -c dmg`, and which could be enabling `-Weverything` warning diagnostics. The code itself might all still be simple enough -- no fancy macros or metaprogramming -- that nothing would need change, but the CLI usage at least could be improved.)

See also #125

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.