gazebosim / gazebosim/sdformat
Inconsistencies between SDF tests, SDF docs, and sdformat/sdf/**/*.sdf files
- Langage dominant
- C++
- Étoiles
- 216
- Forks
- 125
- Merge moyen
- 1 j 14 h
- PR mergées (30 j)
- 14
Description
I apologize for the slightly generic title. I figured that I will create this summative issue instead of creating a new issue for each problem to avoid flooding the issue list (any more than I already have).
There are multiple places where the sdf files used for CI, the SDF spec, and the sdf used to generate XSD bindings disagree. The problem with that is that I can't resolve these issues myself; I don't know which of these is authorative. Likely it should be decided on a case-by-case basis; however, I don't have the authority to make this decision.
Here is the list of mismatches that I am aware currently off:
1. [x] SDF (all versions) `/link/sensor` specifies `@required=0` (meaning 0 or 1 occurrences iirc), but the test `world_with_state.sdf` (v1.6 SDF) (which uses a PR2 model) defines two different sensors in several `.//link`s. I would change `@required=*` in the next SDF version, and remove the additional sensor elements from the test (since 1.6 doesn't allow multiple sensors). The same problem as above occurs in `sensors.sdf`, which appears to specify every possible sensor inside a single link element.. sensors.sdf is SDF v1.7 **Note**: This is fixed [in the scikit-bot schema](https://github.com/FirefoxMetzger/scikit-bot/tree/main/skbot/ignition/sdformat/schema) but not yet fixed in the spec.
3. [x] `sdformat/sdf/**/schema/types.xsd` defines `
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez par comparer la spécification SDF avec world_with_state.sdf, sensors.sdf, schema/types.xsd et les fichiers state.sdf mentionnés dans l’issue. Lisez l’issue 642 concernant le mismatch de temps en double et déterminez avec les maintainers quelle source fait autorité. La tâche est terminée lorsque les tests concernés, la documentation et les fichiers de schéma sont cohérents, et que chaque mismatch est résolu ou explicitement documenté.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- cpp, xml
- Domaine
- documentation, testing
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100