gazebosim / gazebosim/gz-rendering

Unit test coverage: Heightmaps on all cameras

Open
#546 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
81
Forks
90
Avg merge
1d 13h
Merged PRs (30d)
10

Description

After merging PR #545, codeconv reports lower coverage because the heightmap is not being tested in any sensor:

- [x] `Ogre2MaterialSwitcher` (e.g. VisualAt / SelectionBuffer)
- [x] `Ogre2LaserRetroMaterialSwitcher`
- [x] `Ogre2SegmentationMaterialSwitcher`
- [ ] `Ogre2ThermalCameraMaterialSwitcher`
- [ ] Heightmap is a background object (i.e. has no thermal value defined, uses ambient/color instead)
- [ ] Heightmap has an explicit thermal value specified
- [ ] Heightmap does not support heat map texture setting. Unit test should test we properly abort/complain if user requests it.

These tests can only be implemented in Garden, not Fortress (as Heightmap doesn't work with those sensors in Fortress, we just disable the terrain as a workaround).

A unit test (or extending existing tests) to cover the heightmap with each sensor should be written.

This is very low priority for me and anyone can implement it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.