gazebosim / gazebosim/gz-rendering

Improve tests for particle effects

Open
#249 0 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted ogre2.x tests
Dominant language
C++
Stars
81
Forks
90
Avg merge
1d 13h
Merged PRs (30d)
10

Description

## Desired behavior

Better tests for particle effects system, like testing changing params like particle type, size, life time, velocity, duration, etc and verify image output

## Alternatives considered

Testing those params in unit tests, which have already been done, but they do not verify the actual image output

## Implementation suggestion

Add integration tests and verify generated image, e.g. set color and verify pixel rgb value, or change particle size and verify fewer pixels in the image are particles

## Additional context

see comment: https://github.com/ignitionrobotics/ign-rendering/pull/241#issuecomment-778497838

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.