gajus / gajus/babel-plugin-react-css-modules

Passing multiple style props to a child component

Aperta
#306 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
2k
Fork
159
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I have a child component, which accepts multiple props for styles, one for the container, and other for one of the internal elements. Generally, I would just name them something like `className` and `elementClassName`, and get different css classes from the parent in each of the props. With `react-css-modules` though, since the default rule only allows converting `styleName` to `className`, I can not pass different local classes in multiple props, as i can only have 1 `styleName` prop.

One of the way around this seems to be to use named imports instead of anonymous imports and then pass `styles.containerClass` in className and `styles.elementClass` in `elementClassName` prop. This does not require using the `styleName` prop at all.

```
import styles from './some.css';

...
...

...
...
```

This seems alright, and the other existing `styleName` in the file do not break, still work alright and do not need to be changed to `styles.soemthing`, but it is slightly confusing that the named import is being only used at one place, and at the rest of the places the anonymous string value in `styleName` still works fine.

Is there another preferred / prescribed approach to handle the above scenario?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.