CSS Modules

Ouverte
#211 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
20/100
Type d'issue
Fonctionnalité
Clarté
À clarifier
Activité
À l'abandon
Stack technique
django, python
Domaine
frontend, web-dev

Piste de recherche

No files, tests, or entry points are named. Start by reviewing the proposed cssselect, VDOM selector-engine, and JavaScript approaches, along with the related issue #194. The issue needs a chosen design and acceptance criteria before “done” can be evaluated.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

complexity: 0 (highest) priority: 3 (low)
Current Situation

There is built-in method of directly tying a CSS file to a component

Proposed Actions
Design Idea: Apply in-line styles via Python cssselect

We could parse the CSS document using lxml.cssselect and potentially add the styles in-line. This might need us to generate some sort of VDOM-LXML compatibility layer though. Might be difficult to do this in a performant manner, but it would be the easiest way for us to not ever "fall out of date" with new CSS selectors.

Design Idea: Apply in-line styles via Python homebrewed VDOM selector engine

It might be make sense (from a performance standpoint) to homebrew a VDOM-compatible CSS selection engine... There are a couple we can take inspiration from: vtree-select, cssauron. This would be a pretty large undertaking, and gets really tricky with all of the CSS level 3 selectors.

Design Idea: Leverage django_css

Add a css_module decorator that loads a stylesheet using django_css(..., only_once=True) (see here: #194).

By default, it will attempt to load the Django static file named <REACTPY_STYLESHEET_SUBDIR>/<COMPONENT_DOTTED_PATH>.css. But the user will be able to override the path using positional args.

Will need a settings.py configuration setting called REACTPY_STYLESHEET_SUBDIR. Additionally, it makes sense for a manual override to exist within the decorator css_module(subdir="...") for library maintainers to use.

This doesn't really "tie" a piece of CSS to a component. It only ties the load time together.

Design Idea: Apply in-line styles via JavaScript (client sided)

It's also possible for us to instead apply the inline styles client-sided, via some kind of JavaScript. There appears to be a package that does this.

This would be pretty janky in terms of loading behavior.

Langage dominant
Python
Étoiles
357
Forks
22
Merge moyen
10 h 31 min
PR mergées (30 j)
2

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de reactive-python/reactpy-django

Toutes les issues de reactive-python/reactpy-django

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.