`TestBed.overrideComponent` breaks module imports with `@angular/build:unit-test`
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 52/100
- Type d'issue
- Bug
- Clarté
- Plutôt claire
- Activité
- Calme
- Stack technique
- angular, typescript
- Domaine
- build-system, testing
Piste de recherche
Commencez par exécuter la reproduction dans app.spec.ts avec les deux configurations du runner @angular/build:unit-test dans angular.json, puis comparez-la avec @angular-devkit/build-angular:karma. Suivez l’effet de TestBed.overrideComponent(App, {}) sur le TestModule importé et vérifiez le correctif avec le test fourni dans les deux runners ; le test devrait reconnaître test-component et créer App avec succès.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Command
test
Is this a regression?
- Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
No response
Description
Reopening from https://github.com/angular/angular/issues/68363 as I don't feel it was fully answered and I later found the issue is related to the new builder.
When using the @angular/build:unit-test builder, TestBed.overrideComponent breaks imports out of modules. This happens for both vitest and karma runners, so I would assume it is connected to the build, not the test execution.
The issue does not occur when using other builder like @angular-devkit/build-angular:karma
Minimal Reproduction
Plain Angular project + packages needed for running karma
// app.spec.ts
import { Component, NgModule } from '@angular/core';
import { TestBed } from '@angular/core/testing';
@Component({
selector: 'test-component',
template: '',
})
export class TestComponent {}
@NgModule({
imports: [TestComponent],
exports: [TestComponent],
})
export class TestModule {}
@Component({
selector: 'app-root',
imports: [TestModule],
template: ` <test-component></test-component> `,
})
export class App {}
describe('App', () => {
beforeEach(async () => {
await TestBed.configureTestingModule({
imports: [App],
})
.overrideComponent(App, {}) // <= problematic call
.compileComponents();
});
it('should create', () => {
expect(TestBed.createComponent(App)).toBeTruthy();
});
});
// angular.json
...
// fails
"test-vitest": {
"builder": "@angular/build:unit-test",
"options": {
"runner": "vitest"
}
},
// fails
"test-karma": {
"builder": "@angular/build:unit-test",
"options": {
"runner": "karma"
}
},
// this one works
"test-karma-devkit": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"tsConfig": "./tsconfig.spec.json"
}
}
...
Running the test with @angular/build:unit-test it fails for both runners with
Error: NG0304: 'test-component' is not a known element (used in the '_App' component template):
1. If 'test-component' is an Angular component, then verify that it is included in the '@Component.imports' of this component.
2. If 'test-component' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@Component.schemas' of this component to suppress this message.
❯ validateElementIsKnown ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/element_validation.ts:116:14
❯ validateElementIsKnown ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/element.ts:151:4
❯ initializeElement ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/element.ts:127:2
❯ ɵɵelementStart ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/element.ts:218:2
❯ _App_Template ng:/_App.js:6:21
❯ templateFn ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/shared.ts:109:4
❯ executeTemplate ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/render.ts:107:6
❯ renderView ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/render.ts:47:4
❯ renderComponent ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/render.ts:160:4
❯ renderChildComponents ../darwin_arm64-fastbuild-ST-fdfa778d11ba/bin/packages/core/src/render3/instructions/render.ts:140:6
With the @angular-devkit/build-angular:karma it passes as expected.
Also actually overriding something in TestBed.overrideComponent doesn't change the behaviour. I originally discovered this with a test that needs to stub a component. I left it out for simplicity here.
Exception or Error
Your Environment
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ △ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI : 21.2.8
Angular : 21.2.10
Node.js : 24.15.0
Package Manager : npm 10.9.4
Operating System : win32 x64
┌───────────────────────────────┬───────────────────┬───────────────────┐
│ Package │ Installed Version │ Requested Version │
├───────────────────────────────┼───────────────────┼───────────────────┤
│ @angular-devkit/build-angular │ 21.2.8 │ ^21.2.8 │
│ @angular/build │ 21.2.8 │ ^21.2.7 │
│ @angular/cli │ 21.2.8 │ ^21.2.7 │
│ @angular/common │ 21.2.10 │ ^21.2.0 │
│ @angular/compiler │ 21.2.10 │ ^21.2.0 │
│ @angular/compiler-cli │ 21.2.10 │ ^21.2.0 │
│ @angular/core │ 21.2.10 │ ^21.2.0 │
│ @angular/forms │ 21.2.10 │ ^21.2.0 │
│ @angular/platform-browser │ 21.2.10 │ ^21.2.0 │
│ @angular/router │ 21.2.10 │ ^21.2.0 │
│ rxjs │ 7.8.2 │ ~7.8.0 │
│ typescript │ 5.9.3 │ ~5.9.2 │
│ vitest │ 4.1.5 │ ^4.0.8 │
└───────────────────────────────┴───────────────────┴───────────────────┘
Anything else relevant?
No response
- Langage dominant
- TypeScript
- Étoiles
- 27k
- Forks
- 11.8k
- Merge moyen
- 16 h 21 min
- PR mergées (30 j)
- 170
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de angular/angular-cli
-
area: @angular/build gemini-triaged
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
angular/angular-cli#34129 ·
-
Support aube as package manager Ouvertearea: @angular/cli gemini-triaged
Difficulté 2/5 1-3 heures Accessibilité débutants 84/100
angular/angular-cli#34057 ·
-
Can't use an array of hostnames in --allowedHosts cli parameter in @angular/build:dev-server Ouvertearea: @angular/build gemini-triaged
Difficulté 2/5 1-3 heures Accessibilité débutants 74/100
angular/angular-cli#33955 ·
-
area: @angular/cli gemini-triaged
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
angular/angular-cli#33055 · 1 commentaire · 3 réactions ·
-
angular/build:library area: @angular/build gemini-triaged
angular/angular-cli#34131 · 1 personne assignée ·