Unable to programmatically select a single inline element

Ouverte
#2,864 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Calme
Stack technique
typescript
Domaine
frontend

Piste de recherche

Start with packages/core/src/api/blockManipulation/selections/selection.ts and the editor.setSelection entry point mentioned in the issue. Trace how single inline selections are represented and why forcing a ProseMirror selection opens the formatting toolbar. Done means a single inline element can be selected through editor.setSelection and callers can control whether the formatting toolbar opens.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug:P2
What’s broken?

At OpenProject, we're building an extension to have custom work package links for the BlockNote editor.
However, currently the behaviour when clicking on such an inline link is broken:

  1. The user expects after clicking on the element that when Ctrl-C and Ctrl-V are pressed, the work package link is copied
  2. The user expects after clicking on the element and pressing "del" or "backspace" that the element is removed from the document

It would be easy to solve both expectations, if we could select a single inline block. However, this is not possible at the moment via BlockNote, because it's not possible to select a single inline content.

Furthermore, when we force selection via ProseMirror, BlockNote opens a formatting toolbar. This toolbar does not make sense in our case, since you can't e.g. change font boldness or italics on our custom inline work package link.

What did you expect to happen?

What we need is:

  1. Be able to select a single inline element via editor.setSelection
  2. Be able to pass in if we want the formatting toolbar to open or not, e.g. showFormattingToolbar: true|false
Steps to reproduce
  1. Write your own extension with inline elements
  2. Try editor.setSelection on a single inline element
BlockNote version

0.51.3

Environment

No response

Additional context
Image

We would like to solve this in a clean way 🙂 At the moment we're exploring the following options:

  • Set selection via ProseMirror (solves our requirements but opens formatting toolbar)
  • Attach our own handlers which intercept copy-paste, keypress etc. when the inline element was clicked (and remove the handlers when the focus is removed)

If you see other good ways to solve our problem, we're happy about suggestions!

Contribution
  • I'd be interested in contributing a fix for this issue
Sponsor
  • I'm a sponsor and would appreciate if you could look into this sooner than later 💖
Langage dominant
TypeScript
Étoiles
10.2k
Forks
772
Merge moyen
3 j 11 h
PR mergées (30 j)
17

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TypeCellOS/BlockNote

Toutes les issues de TypeCellOS/BlockNote

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.