Remove the deprecated -ld_classic and -fembed-bitcode flags from the NativeScript target
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 3/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 66/100
- Type d'issue
- Bug
- Clarté
- Plutôt claire
- Activité
- Calme
- Stack technique
- ios, javascript
- Domaine
- build-system, mobile-dev
Piste de recherche
Ouvrez v8ios.xcodeproj/project.pbxproj et inspectez les entrées OTHER_LDFLAGS et OTHER_CFLAGS de la target NativeScript pour Debug et Release aux lignes référencées. Supprimez les flags obsolètes, puis compilez et liez chaque slice iOS, simulateur, Mac Catalyst et visionOS listée ; le travail est terminé lorsque tous les slices réussissent, ou lorsqu’une exception propre à visionOS est strictement circonscrite et documentée.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
The NativeScript target carries two linker/compiler flags that Apple has already retired. One of them is on a deprecation clock and will become a hard build failure.
-ld_classic
OTHER_LDFLAGS on the NativeScript target, both Debug and Release (v8ios.xcodeproj/project.pbxproj:2899 and :2992). Every link emits:
ld: warning: -ld_classic is deprecated and will be removed in a future release
It forces the old linker. Apple has said it is going away; when it does, this stops being a warning and starts failing the build.
It was added in bb364f95 ("feat(visionos): support for xros platform", #235), so it was most likely a workaround for a new-linker bug on xros at that time rather than something iOS ever needed. Whatever that bug was, it is worth re-testing against a current Xcode.
-fembed-bitcode
OTHER_CFLAGS on the same two configurations (:2896, :2989). Bitcode was deprecated in Xcode 14 and App Store submission has not accepted it for years. The flag is dead weight.
What needs doing
Remove both, then confirm the framework still links on every slice — arm64-iphoneos, arm64-iphonesimulator, x86_64-iphonesimulator, arm64-maccatalyst, x86_64-maccatalyst, arm64-xros, arm64-xrsimulator. visionOS is the one that matters: it is the platform -ld_classic was introduced for, so if anything regresses it will be there, and a build that only checks iOS proves nothing.
If visionOS does still need the classic linker, the flag should at minimum be narrowed to the visionOS configurations only and carry a comment saying what breaks without it, so the next person is not left guessing.
Not to be confused with
The same links also emit ~174 copies of:
ld: warning: direct access in function '...' from file 'libv8_base_without_compiler.a(...)'
to global weak symbol 'std::__1::piecewise_construct' from file '...ModuleInternalCallbacks.o'
means the weak symbol cannot be overridden at runtime.
Those are benign and out of scope here. V8 is built with chromium's default -fvisibility=hidden while the framework's own translation units use Xcode's default visibility, so both sides emit the same libc++ weak symbol and V8's objects bind to ours directly. The symbol is an empty tag struct used only for compile-time dispatch:
struct _LIBCPP_TEMPLATE_VIS piecewise_construct_t { explicit piecewise_construct_t() = default; };
inline constexpr piecewise_construct_t piecewise_construct = piecewise_construct_t();
It has no state and its address is never compared, so duplicate definitions are indistinguishable. The warning matters for typeinfo/vtable symbols (breaks dynamic_cast and cross-boundary catch) or operator new/delete (breaks allocator replacement) — a classification of a full Release-iphoneos link found all 174 to be the one tag constant and none of those. Matching visibility would silence them, but the framework has no EXPORTED_SYMBOLS_FILE, so -fvisibility=hidden would also hide the ObjC class symbols the public API needs.
- Langage dominant
- JavaScript
- Étoiles
- 150
- Forks
- 43
- Merge moyen
- 3 j 10 h
- PR mergées (30 j)
- 22
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de NativeScript/ios
-
isImplementedInClass leaks the losing sample instance on re-entrant or racing cache population Ouverte
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 38/100
NativeScript/ios#459 · 1 commentaire ·
-
worker.terminate() is a no-op during entry evaluation, and terminating there wedges teardown Ouverte
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 25/100
NativeScript/ios#445 ·
-
question
Difficulté 4/5 3-5 jours Accessibilité débutants 34/100
NativeScript/ios#364 · 2 commentaires ·
-
Difficulté 4/5 3-5 jours Accessibilité débutants 35/100
NativeScript/ios#355 ·
-
Difficulté 4/5 3-5 jours Accessibilité débutants 25/100
NativeScript/ios#292 · 9 commentaires ·
Toutes les issues de NativeScript/ios
Issues similaires
-
enhancement
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
babalae/bettergi-scripts-list#3674 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100
vadimdemedes/ink#1029 ·
-
code-quality refactoring
Difficulté 2/5 1-3 heures Accessibilité débutants 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulté 2/5 1-3 heures Accessibilité débutants 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulté 2/5 1-3 heures Accessibilité débutants 86/100
githubnext/gh-aw-cao#13143 ·