foundweekends / foundweekends/conscript
Make dry run configurable using launchconfig
- Langage dominant
- Scala
- Étoiles
- 477
- Forks
- 59
- Merge moyen
- 1 h 2 min
- PR mergées (30 j)
- 7
Description
migrating from #34
## steps
1. `cs foo` where calling `foo --version` does something undesirable (like waiting for user input forever).
## problem
the installation process calls `foo --version` and does that thing.
## expectations
I would like to propose 2-tier solution to this using `launchconfig` file. Both of them involve adding an _optional_ section `conscript` to `launchconfig` as follows:
```
[conscript]
dry-run: false
dry-run-param: --something-not-version
```
### opt-out
The proposal is that we keep the existing behavior (run script with `--version`) by default, so existing happy conscript authors don't get sniped from the back. In other words, the new `[conscript]` section is totally optional.
If the conscript author just doesn't want to use dry-run option at all, they can opt-out by writing:
```
dry-run: false
```
Upon installation we don't do dry-run, and instead we print some warning saying that the jar's still not downloaded.
### `--help` instead of `--version`
Another scenario is that application does not support `--version`, but has some other harmless option already like `--help`.
```
dry-run-param: --something-not-version
```
This let's them customize to whatever. Again, if it's not specified `--version` is used.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.