fluttercommunity / fluttercommunity/plus_plugins
[Request]: share_plus: option to present the iPad share sheet without a popover arrow
Personne n'a encore pris cette issue.
- Langage dominant
- Dart
- Étoiles
- 1.9k
- Forks
- 1.3k
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Plugin
share_plus
Use case
On iPad the share sheet is a popover, and a popover has an arrow pointing at whatever rect was passed as sharePositionOrigin. That is right when the sheet was opened from a visible control. It is wrong whenever there is no such control: a keyboard shortcut, a finished background export, an action whose source has already scrolled away. Any rect passed in those cases is arbitrary, and iPadOS then draws an arrow pointing at a spot the user never touched.
Since 13.3.0 the plugin centres the sheet when no origin is given, which is the correct position — the arrow still points into empty space next to it.
There is no way around this from application code: ShareParams exposes sharePositionOrigin and nothing else that reaches UIPopoverPresentationController, and permittedArrowDirections does not appear anywhere in the iOS plugin. Other share packages on pub.dev wrap the same UIActivityViewController, so they inherit the same behaviour.
This was previously requested in #359 (July 2021), which the stale bot closed in June 2022 without any human reply; that issue is now locked, so I could not comment there. flutter/flutter#74552 asks for the same thing and is still open. Both name the same reference: the export sheet in Procreate, which is centred and arrow-free.
Proposal
Expose the arrow configuration, ignored on every platform other than iOS/macOS. Two parts that can be judged separately:
1. Pass permittedArrowDirections through. Fully documented and mechanical. permittedArrowDirections is settable since iOS 8 and defaults to any; UIPopoverArrowDirection is an OptionSet, so up/down/left/right map one-to-one.
2. An option for "centred, no arrow". This is the part that closes the request, and the implementation deserves a decision rather than a guess, so here is what I measured on an iPad Air 13-inch (M4) simulator, iPadOS 26.5, presenting a UIActivityViewController exactly as the plugin does:
- An empty option set works. With
popover.permittedArrowDirections = []and a 2×2sourceRectin the centre of the view, the sheet appears centred with no arrow at all, andarrowDirectionreads0afterwards. It is not documented to work, though — Apple describesunknownonly as "The status of the arrow is currently unknown" and says nothing about suppression. sourceItemdoes not help. The docs say that forsourceItem, "In iOS 26 and later, the popover animates from and replaces the specified item" — but that paragraph is aboutUIBarButtonItem/NSToolbarItem. Anchoring to a plainUIView, whichUIPopoverPresentationControllerSourceItemalso accepts, still drew an arrow on iPadOS 26.5 (arrowDirection=2, i.e.down). So the iOS 26 behaviour does not generalise to view items, and Flutter apps have no bar item to anchor to.
I am aware CONTRIBUTING rules out features covering only one platform, and an arrow only exists on iOS and macOS. sharePositionOrigin has exactly the same scope, so there is precedent for a platform-specific parameter here — but I would rather ask than assume. Happy to implement whichever half you consider acceptable.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez au point d’entrée de présentation de UIActivityViewController d’iOS/macOS de share_plus et examinez comment ShareParams.sharePositionOrigin parvient à UIPopoverPresentationController. Déterminez s’il faut exposer permittedArrowDirections, l’option centrée sans flèche, ou les deux, puis ajoutez des tests spécifiques à la plateforme et une documentation démontrant le comportement sélectionné.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- dart, flutter, ios, macos
- Domaine
- desktop, mobile
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- Active
- Clarté
- Plutôt claire
- Accessibilité débutants
- 48/100