fluttercommunity / fluttercommunity/flutter_webview_plugin

onBack stream not closed

Open Beginner friendly
#774 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.5k
Forks
938
PR merge metrics
No merged PRs in 30d

Description

## System info

Issue occurs on: both
Plugin version: 0.3.11
Flutter doctor output:

```
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [Version 10.0.18363.900], locale en-NZ)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[√] Android Studio (version 4.0)
[√] VS Code, 64-bit edition (version 1.46.0)
[√] Connected device (1 available)

• No issues found!
```

## Steps to Reproduce
1. Navigate to the file base.dart in the plugin lib.
2. scroll down to dispose method.

![image](https://user-images.githubusercontent.com/9078067/85355181-27f3d300-b560-11ea-9241-a3f953aab2a3.png)

as you can see also in the image, the _onBack stream controller is created but never closed in the dispose. Not sure if this was on purpose or not.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open lib/base.dart and inspect the dispose method, then trace the _onBack stream controller created there. Confirm whether disposal should close that controller, and verify that the onBack stream is closed when the plugin is disposed.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart, flutter
Domain
mobile-dev
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.