fluttercommunity / fluttercommunity/flutter_webview_plugin

Property supportMultipleWindows of Android WebView needs to have onCreateWindow implemented

Open
#569 8 comments 0 reactions 0 assignees View on GitHub
ANDROID enhancement
Dominant language
Java
Stars
1.5k
Forks
938
PR merge metrics
No merged PRs in 30d

Description

Issue occurs on: Android
Plugin version: 0.3.8
Flutter doctor output:

```
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.9.1+hotfix.2, on Mac OS X 10.14.6 18G87, locale en-RO)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.38.1)
[✓] Connected device (2 available)

• No issues found!
```

I am trying to implement login with Facebook. During the process, Facebook needs to open a new window and then to do the redirect. On Android native you would set supportMultipleWindows to true on the WebView and you would catch the onCreateWindow() callback and open the url in a new WebView.

I tried setting supportMultipleWindows: true on the WebViewScaffold but then pressing the Login Facebook button does not do anything.

The documentation on Android WebView says that if you set supportMultipleWindows: true you NEED to override onCreateWindow(). Is this possible with your plugin? Am I missing something obvious? Why would you have the supportMultipleWindows property on the WebViewScaffold but not support for the corresponding onCreateWindow()?

Any help is greatly appreciated because I am stuck.

Contributor guide

No contributing guide indexed for this repository

Research direction

No file, test, or entry point is named. Start by tracing the Android WebViewScaffold handling of supportMultipleWindows and the onCreateWindow callback; done means the Facebook login flow opens the new window and completes its redirect on Android.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, dart, java
Domain
mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.