flutter / flutter/devtools

Don't rely on IDE=VSCode in querystring for behaviour

Offen
#9,811 9 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
ide-integration ide: vs-code P1
Vorherrschende Sprache
Dart
Sterne
1.7k
Forks
404
Ø Merge
6 T. 17 Std.
Gemergte PRs (30 T.)
18

Beschreibung

https://github.com/Dart-Code/Dart-Code/issues/5970 is a request to change the values pass in the querystring passed to DevTools to include the proper IDE name and not hard-coded values like "VSCode" (which prevents distinguishing VS Code forks using the same extension, like Antigravity or Cursor).

However, there are some places that currently assume "VSCode" here in DevTools that I think require reviewing first (or, we need to pass two values).

1. Survey IDE filters
2. WASM/JS fallback message
3. Property editor documentation link

## 1. Survey IDE Filters

https://github.com/flutter/devtools/blob/6046c5bef397cbac6eb9e5d535436ef2b3bb6dbb/packages/devtools_app/lib/src/shared/development_helpers.dart#L229-L231

I don't know if this is used, but if it is, it would need to cover each of the variations of editors now. I think we could either:

1. Update this comment to mention this is based on DASH__IDE_NAME and include updated examples ("Visual Studio Code", "Antigravity", "Cursor")
2. Pass two values in querystring, DASH__IDE_NAME and also DASH__TOOL (or DASH__PLUGIN_NAME) which are constant across different IDE flavours using the same plugin/extension

## 2. WASM/JS fallback message

https://github.com/flutter/devtools/blob/6046c5bef397cbac6eb9e5d535436ef2b3bb6dbb/packages/devtools_app/lib/src/shared/preferences/preferences.dart#L239-L250

It controls whether to show a message if the wasm version fails. I'm not sure if this is necessary anymore, as I think there were WASM changes to not require COI? If so, this code could probably just be deleted (and if not, I think won't cause any problems). Needs testing though.

## 3. Property editor documentation link

https://github.com/flutter/devtools/blob/6046c5bef397cbac6eb9e5d535436ef2b3bb6dbb/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_panel.dart#L172-L179

If IDE is not exactly "VSCode" this will link to the Android Studio docs.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.