flutter / flutter/devtools

Latest stager is incompatible with latest Dart SDK

Offen
#9,497 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
P2 testing
Vorherrschende Sprache
Dart
Sterne
1.7k
Forks
404
Ø Merge
6 T. 17 Std.
Gemergte PRs (30 T.)
18

Beschreibung

A roll of the Dart SDK into Flutter has revealed that devtools_app is incompatible with the latest Dart SDK.

devtools_app depends on [stager](https://github.com/bryanoltman/stager); the latest release of stager depends on a specific range of source_gen and of the analyzer package, both of which prohibit analyzer 8.x.y or 9.x.y.

The latest Dart SDK on the main channel includes dot-shorthand syntax in `dart:developer` sources. Any version of the analyzer package predating 8.4.1 cannot parse this code.

What to do?

* Bump stager - In June, I was able to land a PR in the stager GitHub repo that [widens the constraint on source_gen](https://github.com/bryanoltman/stager/commit/16c8bdc023df1c92211980124fc2956323aee8df). This code has not been published on pub, and the repo has been idle since that PR. This PR was actually for a different issue, and bumping the constraint to include source_gen ^3.0.0, and also to require analyzer ^8.0.0 or ^9.0.0, would be new work.
* Drop stager - Can we drop stager? Can we drop it temporarily so that devtools can continue to be tested in the Flutter customer tests? It seems to be mostly used in some tests, as it is mostly referenced in `test/test_infra/scenes`.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.