flutter / flutter/devtools

Move chrome test utilities into DDS

未关闭
#9,408 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
P3 testing
主要语言
Dart
星标
1.7k
派生
404
平均合并
6 天 17 小时
30 天内合并 PR
18

描述

The Chrome test utilities (deleted in https://github.com/flutter/devtools/pull/9372, change reverted when rolling DevTools into the Dart SDK) are not being used in DevTools, but are being used in the `devtools_server` tests in DDS.

```
error - dds/test/devtools_server/instance_reuse_test.dart:73:30 - Undefined name 'Chrome'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
error - dds/test/devtools_server/instance_reuse_test.dart:117:30 - Undefined name 'Chrome'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
error - dds/test/devtools_server/server_connection_common.dart:85:28 - Undefined name 'Chrome'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
error - dds/test/devtools_server/utils/server_driver.dart:93:9 - Undefined name 'useChromeHeadless'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
error - dds/test/devtools_server/utils/server_driver.dart:93:30 - Undefined name 'headlessModeIsSupported'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier

5 issues found.
```

We should consider moving these test utilities out of DevTools and into DDS.

贡献指南

打开贡献指南

调研方向

首先检查 pull request 9372 中的删除内容,然后检查 dds/test/devtools_server/instance_reuse_test.dart、server_connection_common.dart 和 utils/server_driver.dart,查找缺失的 Chrome 工具。确认之前是如何提供这些工具的,并将所需的测试支持移到 DDS 中。完成的标准是:这些测试能够解析 Chrome、useChromeHeadless 和 headlessModeIsSupported,且不再出现报告的 analyzer 错误。

由索引模型根据 Issue 内容生成。

评估

技术栈
dart
领域
testing
Issue 类型
重构
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。