flutter / flutter/devtools

Flutter service extensions disabled after a hot-restart

Offen
#8,490 5 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @elliette Auf GitHub ansehen
P2 reproduce to verify testing
Vorherrschende Sprache
Dart
Sterne
1.7k
Forks
404
Ø Merge
6 T. 17 Std.
Gemergte PRs (30 T.)
18

Beschreibung

I noticed that if you start a test with a connection to a live app, trigger a hot-restart, and then try to call a service extension from Flutter, the test will fail because the service extension is never re-registered.

I'm pretty sure this is the same underlying cause as https://github.com/flutter/devtools/issues/7313, when DWDS was connecting directly to the VM Service URI instead of the DDS URI.

Because DDS intercepts the `streamListen` request and [sends back all of the service extensions it is aware of](https://github.com/dart-lang/sdk/blob/df3d7e339dd24d6867b64f0867575f80953d0d70/pkg/dds/lib/src/stream_manager.dart#L291), these service extensions are never sent back to the DevTools test infra VM service connection.

Here is the code we will likely need to modify (where we get the VM service URI and connect to it):

https://github.com/flutter/devtools/blob/9bd0125579f2d57c374eabac6eb1f162b02b9f87/packages/devtools_app/test/test_infra/flutter_test_driver.dart#L327-L358

@bkonyi Do you happen to know how we could get the DDS URI here instead? Thanks!

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.