flutter / flutter/devtools

[Inspector V2][Tech debt] `FlexLayoutExplorer` refactors

未关闭
#8,237 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
inspector-2.0-polish P2 tech debt
主要语言
Dart
星标
1.7k
派生
404
平均合并
6 天 17 小时
30 天内合并 PR
18

描述

After https://github.com/flutter/devtools/pull/8202, there are a few refactors that should be made to the `FlexLayoutExplorerWidget` (making a tracking issue for this work instead of trying to do it all in https://github.com/flutter/devtools/pull/8202 since that PR is already huge).

- [ ] Because `BoxLayoutExplorerWidget` is no longer a subclass of `LayoutExplorerWidget`, `FlexLayoutExplorerWidget` is now its only subclass. Therefore, its logic can be combined with `LayoutExplorerWidget`.
- [ ] Now that the `FlexLayoutExplorerWidget` is in a tabbed view, the animation is never visible. Therefore the animation should be removed.
- [ ] A lot of the logic in `LayoutExplorerWidget` has been pulled out into the `InspectorController` (e.g., `_loadLayoutPropertiesForNode`.) Instead of having this logic in two places, we should refactor the `FlexLayoutExplorer` to accept the layout properties etc. as arguments instead of computing them itself.
- [ ] Would also be nice to rename `BoxLayoutExplorerWidget` to `BoxLayoutExplorer` and `FlexLayoutExplorerWidget` to `FlexLayoutExplorer`.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。