flutter / flutter/devtools

`ServiceExtensionManager` wrongly assumes service extensions are always registered on the main isolate

Aperta
#7,323 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
bug P1
Lingua principale
Dart
Stelle
1.7k
Fork
404
Merge medio
6g 17h
PR unite (30g)
18

Descrizione

**Reproduction Steps:**

1. Comment out `--disable-vm-service` flag from `packages/flutter_tools/lib/src/test/runner.dart`
2. Run `flutter test --experimental-faster-testing test/material` in `flutter/packages/flutter/`
3. Copy the VM service URI into DevTools

DevTools will fail to connect to the test runner. This is due to the fact that the [service extension registration event handler](https://github.com/flutter/devtools/blob/master/packages/devtools_app_shared/lib/src/service/service_extension_manager.dart#L59) assumes the events are from the main isolate (in this example, the service extensions are registered by the Flutter framework). However, the main isolate for the test runner consists of bootstrapping code for the test and doesn't register the same service extensions, so the invocations of the service extensions fail, preventing DevTools from connecting to the application.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.