flutter / flutter/devtools

Do not break on exceptions thrown in undebuggable code if caught in undebuggable code

Abierto
#5,883 20 comentarios 6 reacciones 0 asignados Ver en GitHub
P2
Lenguaje dominante
Dart
Estrellas
1.7k
Forks
404
Merge medio
6 d 17 h
PR fusionados (30 d)
18

Descripción

There are several issues where users were confused by the the "Break on all exceptions" option when an exception is thrown in core library code **and handled in core library code**, e.g.
https://github.com/dart-lang/sdk/issues/52615
https://github.com/dart-lang/sdk/issues/52423

I proposed that, by default, if an exception is thrown in code that is not debuggable and will be caught in code that is not debuggable, then the debugger will not break even if "Break on all exceptions" is enabled.

For example:
```dart
part of dart.core

void _foo() {
throw Exception('foo');
}

void bar() {
try {
_foo();
} on Exception {};
}
```

Calling `bar` **should not cause** the debugger to break on `throw Exception('foo');` because the exception is both throw and caught in undebuggable code i.e. it is just an implementation detail of `bar`.

Another example:

```dart
part of dart.core

void _foo() {
throw Exception('foo');
}

void bar() {
_foo();
}

// User code:
void main() {
try {
bar();
} on Exception {}
}
```

Calling `bar` **should cause** the debugger to break on `throw Exception('foo');` because the exception is caught in debuggable code.

This UX will require VM changes.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.