flutter / flutter/devtools

Do not break on exceptions thrown in undebuggable code if caught in undebuggable code

Open
#5,883 20 comments 6 reactions 0 assignees View on GitHub
P2
Dominant language
Dart
Stars
1.7k
Forks
404
Avg merge
6d 17h
Merged PRs (30d)
18

Description

There are several issues where users were confused by the the "Break on all exceptions" option when an exception is thrown in core library code **and handled in core library code**, e.g.
https://github.com/dart-lang/sdk/issues/52615
https://github.com/dart-lang/sdk/issues/52423

I proposed that, by default, if an exception is thrown in code that is not debuggable and will be caught in code that is not debuggable, then the debugger will not break even if "Break on all exceptions" is enabled.

For example:
```dart
part of dart.core

void _foo() {
throw Exception('foo');
}

void bar() {
try {
_foo();
} on Exception {};
}
```

Calling `bar` **should not cause** the debugger to break on `throw Exception('foo');` because the exception is both throw and caught in undebuggable code i.e. it is just an implementation detail of `bar`.

Another example:

```dart
part of dart.core

void _foo() {
throw Exception('foo');
}

void bar() {
_foo();
}

// User code:
void main() {
try {
bar();
} on Exception {}
}
```

Calling `bar` **should cause** the debugger to break on `throw Exception('foo');` because the exception is caught in debuggable code.

This UX will require VM changes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.