flutter / flutter/devtools

Reducing Selection to only rely on nodeIndexCalculator and not on nodeIndex

Open
#4,266 0 comments 0 reactions 0 assignees View on GitHub
P3 screen: app size table component
Dominant language
Dart
Stars
1.7k
Forks
404
Avg merge
6d 17h
Merged PRs (30d)
18

Description

**Currently**
Selection class in table.dart contains both nodeIndex and nodeIndexCalculator. https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/shared/table.dart#L321

**Future**
Only NodeIndexCalculator is needed and all changes to nodeIndex can be migrated to nodeIndexCalculator. Only changes of nodeIndex is found in memory_heap_tree.

Contributor guide

Open the contributing guide

Research direction

Start in packages/devtools_app/lib/src/shared/table.dart, where Selection currently contains nodeIndex and nodeIndexCalculator. Then inspect memory_heap_tree for every nodeIndex change and trace how those updates can move to nodeIndexCalculator. Done means Selection no longer relies on nodeIndex and the memory heap tree uses the calculator consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
devtools
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.