flutter / flutter/devtools

Track down why sectionSpacing needs to be scaled

Ouverte
#3,306 1 commentaire 0 réactions 1 personne assignée Réclamée par @kenzieschmoll Voir sur GitHub
cleanup fix it friday flame_chart P3
Langage dominant
Dart
Étoiles
1.7k
Forks
404
Merge moyen
6 j 17 h
PR mergées (30 j)
18

Description

sectionSpacing in flame_chart needs to be scaled otherwise negative padding values are generated.
Track down what the bug in the current logic is so that this can be avoided.

This is surprising to me that this needs to be scaled at all. This is supposed to be the vertical spacing between sections of the flame chart, and should be independent of the size of the rows (which would be affected by font size).

rowOffsetForTopPadding is the number of rows we want to offset for padding at the top of the flame chart. For example, we need more rows of padding in the timeline flame chart that has the timestamp grid at the top than we need in the Cpu profiler flame chart, which doesn't have anything to account for at the top.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.