flutter / flutter/devtools

Make really slow frames clearer in the performance page bar chart

Aperta
#3,094 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
new feature P3 screen: performance
Lingua principale
Dart
Stelle
1.7k
Fork
404
Merge medio
6g 17h
PR unite (30g)
18

Descrizione

Currently a slightly slow frame (32ms) which a user is unlikely to notice unless it is a glitch in the middle of a smooth animation looks the same as catastrophic jank (200+ms)

Idea: rather than showing a bar chart, show a timeline (perhaps with gaps omitted for periods of inactivity). That way, jank for 300ms would look visually longer than jank for 32 ms.
This is similar to what Chrome DevTools does where they show the frame rate per ms in the performance page instead of a bar chart.
A bonus of this design is it makes it easier to link up time ranges in the flame chart with the bar chart as both now have a consistent X axis. This makes it practical to visualize what time range from the flame chart is visible.

Risk of this approach: makes it less clear how long each frame took to render.
https://user-images.githubusercontent.com/1226812/121062165-9c2b8480-c779-11eb-9081-0a861a942ae2.mp4

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.