firefox-devtools / firefox-devtools/vscode-firefox-debug
tabFilter no longer filters tabs
- Dominant language
- TypeScript
- Stars
- 447
- Forks
- 76
- PR merge metrics
- No merged PRs in 30d
Description
Setting the `tabFilter` property in the config or relying on the automatically generated `tabFilter` per the documentation does not actually result in any filtered tabs. All tabs are attached regardless of filters. This gums up my console log with all console messages from all tabs I have open, rather than just the ones relevant to the app I'm trying to debug, which is quite annoying.
This seems to be a regression introduced in a29df5f. The `tabFilter` config option is only verified against processes, not tabs:
```js
const url = targetActor.target.url;
if (
descriptorActor.type === 'process' && !targetActor.target.addonId && url &&
(!this.config.tabFilter.include.some(tabFilter => tabFilter.test(url)) ||
this.config.tabFilter.exclude.some(tabFilter => tabFilter.test(url)))
) {
skip = true;
}
```
This is allowing all tabs through regardless of URL.
Contributor guide
Research direction
Start by locating the tab-filtering condition introduced in commit a29df5f and trace how config.tabFilter is applied to process and tab descriptors. Reproduce the issue with include and exclude filters, then verify that tabs are attached only when their URLs satisfy the configured filters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100