firefox-devtools / firefox-devtools/vscode-firefox-debug

tabFilter no longer filters tabs

Open
#385 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
447
Forks
76
PR merge metrics
No merged PRs in 30d

Description

Setting the `tabFilter` property in the config or relying on the automatically generated `tabFilter` per the documentation does not actually result in any filtered tabs. All tabs are attached regardless of filters. This gums up my console log with all console messages from all tabs I have open, rather than just the ones relevant to the app I'm trying to debug, which is quite annoying.

This seems to be a regression introduced in a29df5f. The `tabFilter` config option is only verified against processes, not tabs:


```js
const url = targetActor.target.url;
if (
descriptorActor.type === 'process' && !targetActor.target.addonId && url &&
(!this.config.tabFilter.include.some(tabFilter => tabFilter.test(url)) ||
this.config.tabFilter.exclude.some(tabFilter => tabFilter.test(url)))
) {
skip = true;
}
```

This is allowing all tabs through regardless of URL.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.