firebase / firebase/firebase-cpp-sdk

[Bug] Going offline/online after authenticating causes crash

Ouverte
#594 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
api: database needs-info type: bug
Langage dominant
C++
Étoiles
326
Forks
137
Merge moyen
3 j 9 h
PR mergées (30 j)
5

Description

### [REQUIRED] Please fill in the following fields:

* Pre-built SDK from the [website](https://firebase.google.com/download/cpp) or open-source from this repo: open source
* Firebase C++ SDK version: 8.1.0
* Problematic Firebase Component: database
* Other Firebase Components in use: auth
* Platform you are using the C++ SDK on: mac, linux
* Platform you are targeting: desktop

### [REQUIRED] Please describe the issue here:

An assert failure occurs if going offline/online too quickly after being authenticated. Persistent connections do not cancel their "fetch token" async work, and if two run at the same time, the app may crash.

> ASSERT: [...]/firebase-cpp-sdk/database/src/desktop/connection/persistent_connection.cc(578): connection_state_ == kDisconnected

This is problematic for my actual app, as I want to be able to reconnect as soon as the network becomes reachable. If the network becomes unreachable/reachable in rapid succession (very common), it will crash because of this race, which is 100% reproducible.

I noticed that in the ObjC SDK, a guard was added to make sure the "fetch token" routine was still valid when handling its result by using a simple counter. I'd imagine this would have a similarly simple fix.

#### Steps to reproduce:

Have you been able to reproduce this issue with just the [Firebase C++ quickstarts](https://github.com/firebase/quickstart-cpp) ? yes
What's the issue repro rate? 100%

#### Relevant Code:

Add the following to `desktop/testapp/src/common_main.cc` after authenticating (in quickstart-cpp):

```cpp
database->GoOffline();
database->GoOnline();
```

If some time has elapsed after authenticating (e.g., the database is connected), you can still reproduce it if you call GoOffline() / GoOnline() more than once.

```cpp
database->GoOffline();
database->GoOnline();
database->GoOffline();
database->GoOnline();
```

Here's a forked version of quickstart-cpp with the modifications in-place: https://github.com/mikepulaski/quickstart-cpp/tree/auth-token-race

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.