firebase / firebase/firebase-android-sdk

[Crashlytics] cyclic dependency between gradle tasks becuase of injectCrashlyticsBuildIdsRelease depends on CMakeBuild

Abierto
#6,167 4 comentarios 0 reacciones 0 asignados Ver en GitHub
api: crashlytics type: feature request
Lenguaje dominante
Java
Estrellas
2.6k
Forks
710
Merge medio
3 d 1 h
PR fusionados (30 d)
34

Descripción

I couldn't add comment to the already closed issue https://github.com/firebase/firebase-android-sdk/issues/5354 thus opened new one.

Original description

Environment
Android Studio version: Iguana 2023.2.1
Firebase Component: Crashlytics Gradle Plugin
Component version: 2.9.9 (But started in 2.9.5)
The problem
Cyclic dependency between gradle tasks after trying to upgrade Crashlytics Gradle Plugin to 2.9.9.
In our setup we first build java/kotlin code, obfuscate it using R8, then use the R8 outputs to obfuscate JNI headers. This makes the buildCMake task depend on building java/kotlin code and R8.

After updating to 2.9.9 the injectCrashlyticsBuildIdsRelease task kicks in which seems to be necessary to mergeReleaseResources but at the same time depends on outputs from the native build which is the opposite order we have in our code. This causes cyclic dependency between gradle tasks. See output from the console:
```
:app:buildCMakeRelWithDebInfo[armeabi-v7a]
\--- :app:configureCMakeRelWithDebInfo[armeabi-v7a]
\--- :libom_generated:generateReleaseJniObfuscation
+--- :libom_generated:generateReleaseJniHeaders
| \--- :app:compileReleaseJavaWithJavac
| +--- :app:compileReleaseKotlin
| | +--- :app:dataBindingGenBaseClassesRelease
| | | +--- :app:mergeReleaseResources
| | | | \--- :app:injectCrashlyticsBuildIdsRelease
| | | | \--- :app:stripReleaseDebugSymbols
| | | | \--- :app:mergeReleaseNativeLibs
| | | | \--- :app:buildCMakeRelWithDebInfo[armeabi-v7a] (*)
| | | \--- :app:parseReleaseLocalResources
| | | \--- :app:packageReleaseResources
| | | \--- :app:injectCrashlyticsBuildIdsRelease (*)
| | +--- :app:kaptReleaseKotlin
| | | \--- :app:kaptGenerateStubsReleaseKotlin
| | | +--- :app:dataBindingGenBaseClassesRelease (*)
| | | +--- :app:kspReleaseKotlin
| | | | +--- :app:generateReleaseSources
| | | | | \--- :app:injectCrashlyticsBuildIdsRelease (*)
| | | | \--- :app:processReleaseResources
| | | | +--- :app:mapReleaseSourceSetPaths
| | | | | \--- :app:injectCrashlyticsBuildIdsRelease (*)
| | | | +--- :app:mergeReleaseResources (*)
| | | | \--- :app:parseReleaseLocalResources (*)
| | | \--- :app:processReleaseResources (*)
| | +--- :app:kspReleaseKotlin (*)
| | \--- :app:processReleaseResources (*)
| +--- :app:dataBindingGenBaseClassesRelease (*)
| +--- :app:generateReleaseSources (*)
| +--- :app:kaptReleaseKotlin (*)
| +--- :app:kspReleaseKotlin (*)
| \--- :app:processReleaseResources (*)
\--- :libom_generated:generateReleaseProguardMapping
\--- :app:compileReleaseJavaWithJavac (*)
```

In the mentioned issue https://github.com/firebase/firebase-android-sdk/issues/5354 there was a suggestion to generate the R8 mapping upfront and provide that mapping to R8 using the `-applymapping` rule.
We started investigating this option. We used KSP to generate the preliminary mapping file. However we faced an issue where JNI headers are generated by the java compiler (`javac -h`). This still establish the task order where native code can only be compiled after `javac/kotlinc`.

We are currently investigating if we could utilize the KSP to generate the JNI headers as well. However I think you should really consider the idea of keeping the build ids in assets rather than as resources.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza reproduciendo el grafo de tareas en el que participan injectCrashlyticsBuildIdsRelease, mergeReleaseResources, stripReleaseDebugSymbols y buildCMakeRelWithDebInfo, usando las versiones de Android Studio y del plugin de Crashlytics indicadas en el informe. Rastrea las dependencias de recursos y de compilación nativa de Crashlytics Gradle Plugin; se considera completado cuando el grafo de tareas de release no tiene ciclos y los build IDs y las salidas nativas siguen completándose correctamente.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
android, java, kotlin
Área
build-system, mobile
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.