firebase / firebase/firebase-admin-python

Better Error handling for empty token list in Messaging send_each_multicast

Abierto
#792 1 comentario 4 reacciones 0 asignados Ver en GitHub
api: messaging type: feature request
Lenguaje dominante
Python
Estrellas
1.2k
Forks
359
Merge medio
5 d 6 min
PR fusionados (30 d)
2

Descripción

**Problem**
Non-descriptive error message returned when sending multicast message with empty device token list. Currently the empty list of tokens propagates throughout the code and results in an Unknown Error type with a vague error message as follows: "Unknown error while making remote service calls: max_workers must be greater than 0". This error seems to originate [here](https://github.com/firebase/firebase-admin-python/blob/master/firebase_admin/messaging.py#L443) as the Threadpool is created with max_workers based on the length of the messages parameter, which is ultimately dependent on the number of tokens in the Message object.

**Describe the solution you'd like**
Check the length of device tokens directly in the send_each_multicast method and return a descriptive ValueError in the event of an empty list. [here](https://github.com/firebase/firebase-admin-python/blob/master/firebase_admin/messaging.py#L161)

**Describe alternatives you've considered**
Check the length of the message directly in the send_each class method [here](https://github.com/firebase/firebase-admin-python/blob/32b900b0b7f9d8f453f821bf684bf7023c799808/firebase_admin/messaging.py#L425).

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.