firebase / firebase/firebase-admin-python

[FR] Allow `messaging.subscribe_to_topic` to return more verbose information on failure

Abierto
#690 7 comentarios 0 reacciones 0 asignados Ver en GitHub
api: messaging needs-triage type: feature request
Lenguaje dominante
Python
Estrellas
1.2k
Forks
359
Merge medio
5 d 6 min
PR fusionados (30 d)
2

Descripción

**Is your feature request related to a problem? Please describe.**
It frustrates our team that each time our mobile app is updated and our users open the app, a new `device_id` is generated. We are saving this new device_id to the user, because we can't know **for sure** that the user haven't just bought a new phone and installed the app into that new phone as well. This leads to the problem that when we subscribe users to a topic, with all their device ids, we get many `Errors ['NOT_FOUND', 'NOT_FOUND', 'NOT_FOUND', 'NOT_FOUND', 'NOT_FOUND', 'NOT_FOUND']` returned.

**Describe the solution you'd like**
We'd like that the API returns a list of failed `device_id`s so that we can delete those from our database. We'd love to see this extended to `messaging.unsubscribe_from_topic` as well.

**Describe alternatives you've considered**
Digging through the firebase code doesn't give any hints that the information we're looking for is discarded in transit.

**Additional context**
Code example:
```python
from firebase_admin import messaging

def do_subscribe(tokens, topic):
response = messaging.subscribe_to_topic(tokens, topic)
if response.failure_count > 0:
logger.error(
f"Errors {list(map(lambda e: e.reason, response.errors))}",
exc_info=False,
)
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.